Structure msm_audio_stats is copied to userland with some fields unitialized.
It leads to leaking of contents of kernel stack memory.

Signed-off-by: Vasiliy Kulikov <[email protected]>
---
 drivers/staging/dream/qdsp5/audio_in.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/dream/qdsp5/audio_in.c 
b/drivers/staging/dream/qdsp5/audio_in.c
index b51fa09..a14f7ce 100644
--- a/drivers/staging/dream/qdsp5/audio_in.c
+++ b/drivers/staging/dream/qdsp5/audio_in.c
@@ -612,6 +612,7 @@ static long audio_in_ioctl(struct file *file,
 
        if (cmd == AUDIO_GET_STATS) {
                struct msm_audio_stats stats;
+               memset(&stats, 0, sizeof(stats));
                stats.byte_count = atomic_read(&audio->in_bytes);
                if (copy_to_user((void *) arg, &stats, sizeof(stats)))
                        return -EFAULT;
-- 
1.7.0.4

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to