> From: Greg KH [mailto:[email protected]]
> Sent: Monday, November 01, 2010 1:43 PM
> Why did I get two different copies of some of these patches?  Are they
> different?

They are the same.
Initially, I sent all 10 patches out at the same time, but I only saw 5 of them 
in my mail box. So I re-sent the 5 missing ones. Half hour later, I found the 5 
previous missing emails were not lost, and received again at a later time.

> >  /* The one and only */
> > -struct hv_context gHvContext = {
> > -   .SynICInitialized       = false,
> > -   .HypercallPage          = NULL,
> > -   .SignalEventParam       = NULL,
> > -   .SignalEventBuffer      = NULL,
> > +struct hv_context g_hv_context = {
> 
> What is the "g_" for?  Why are you keeping the unneeded, and unwanted
> hungarian notation around?  Please don't do that.

The "g_" was used for global variables. I also saw some other global variables 
with the hungarian notation. Since this notation is not related to camel case 
conversion, how about we remove the hungarian notations in a separate patch?

Thanks,

- Haiyang

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to