Brandon,
That looks right. Thanks, Hank. On Nov 15, 2010, at 19:56, "Brandon Philips" <[email protected]> wrote: > Hello- > > I think this explanation is correct. Right? > > I was going to remove netvsc_set_multicast_list() so I think it is worth > adding a comment since it isn't immediately clear why you would want > this. > > Thanks, > > Brandon > > [PATCH] hv: add explanation of no-op set_multicast_list > > Signed-off-by: Brandon Philips <[email protected]> > > --- > drivers/staging/hv/netvsc_drv.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/hv/netvsc_drv.c b/drivers/staging/hv/netvsc_drv.c > index 1415352..f527e5f 100644 > --- a/drivers/staging/hv/netvsc_drv.c > +++ b/drivers/staging/hv/netvsc_drv.c > @@ -66,6 +66,9 @@ MODULE_PARM_DESC(ring_size, "Ring buffer size (# of > pages)"); > /* The one and only one */ > static struct netvsc_driver_context g_netvsc_drv; > > +/* no-op so the netdev core doesn't return -EINVAL when modifying the the > + * multicast address list in SIOCADDMULTI. hv is setup to get all multicast > + * when it calls RndisFilterOnOpen() */ > static void netvsc_set_multicast_list(struct net_device *net) > { > } > -- > 1.7.2.2 > > _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
