On Tue, Nov 23, 2010 at 2:53 PM, Jiri Slaby <[email protected]> wrote: > On 11/23/2010 01:29 PM, Marek Belisko wrote: >> Use simple misc device for ioctl driver funtionality testing. >> >> Signed-off-by: Marek Belisko <[email protected]> >> --- >> drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c | 90 >> ++++++++++++++++++--- >> 1 files changed, 77 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c >> b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c >> index 1aec926..d1784a3 100644 >> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c >> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_chdev.c >> @@ -32,6 +32,7 @@ >> #include <linux/poll.h> >> #include <linux/netdevice.h> >> #include <linux/delay.h> >> +#include <linux/miscdevice.h> >> >> #include <linux/fs.h> >> #include <linux/kmod.h> >> @@ -78,6 +79,47 @@ static struct file_operations ft1000fops = >> .llseek = no_llseek, >> }; >> >> +struct ft1000_misc_device { >> + struct miscdevice dev; >> + int inf_id; >> +}; >> + >> +#define FREE_ID (0xFF) >> + >> +/* we support just 3 devices */ >> +#define MAX_DEVICE 3 > > No, why this should be converted to miscdevice? Leave it as chrdev. Is there any problem with using miscdev? Old interface create /dev nodes with calling kernel thread and some usermode_helper or whatever. Just convert to misc dev where this is done automatically. > > regards, > -- > js >
thanks, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite icq: 290551086 web: http://open-nandra.com _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
