On Thu, Jan 20, 2011 at 06:50:02PM +1100, [email protected] wrote:
> From: Michael Ahern <[email protected]>
>
> This patch resolves braces and KERN_ warnings by checkpatch.pl
> Warnings: printk() should include KERN_ facility level, removed unnecessary
> braces, lines over 80 chars
break the commit log in 72 chars
> @@ -246,7 +246,12 @@ static void tty_setspeed(struct file *f, int speed)
> struct termios settings;
>
> tty_ioctl(f, TCGETS, (unsigned long)&settings);
> -/* printk("Speed: %d\n", settings.c_cflag & (CBAUD | CBAUDEX)); */
> +
> + /* printk("Speed: %d\n", settings.c_cflag & (CBAUD | CBAUDEX));
> + * better
> + * pr_info("Speed: %d\n", settings.c_cflag & (CBAUD | CBAUDEX));
> + */
since you're fixing coding style, you might as well use the correct
multi-line comment style:
/*
* printk(....
* better
* pr_info(....
*/
--
balbi
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
