On Wed, Feb 09, 2011 at 01:12:48AM +0200, Tomas Winkler wrote:
> +
> +     return 0xFF & rc;

You didn't introduce this, but it's wrong.  It's masking out negative
error codes.  The caller does check for error codes.  Probably it 
would make more sense to just return rc directly...  I'm not sure what
was intended here.

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to