On 22/02/11 19:36, Manohar Vanga wrote: > Remove unreachable code from vme_register_bridge > > Signed-off-by: Manohar Vanga <[email protected]>
Yeah - that's there from development. If the function needed to be extended, that's the next part of the error path. Not sure how leaving lines like this are viewed in the kernel code, I'm happy for this to be removed if it's not considered good practice. In that case: Acked-by: Martyn Welch <[email protected]> Martyn > --- > drivers/staging/vme/vme.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/vme/vme.c b/drivers/staging/vme/vme.c > index d9fc864..88bf455 100644 > --- a/drivers/staging/vme/vme.c > +++ b/drivers/staging/vme/vme.c > @@ -1363,7 +1363,6 @@ int vme_register_bridge(struct vme_bridge *bridge) > > return retval; > > - i = VME_SLOTS_MAX; > err_reg: > while (i > -1) { > dev = &bridge->dev[i]; -- Martyn Welch (Principal Software Engineer) | Registered in England and GE Intelligent Platforms | Wales (3828642) at 100 T +44(0)127322748 | Barbirolli Square, Manchester, E [email protected] | M2 3AB VAT:GB 927559189 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
