> -----Original Message----- > From: Joe Perches [mailto:[email protected]] > Sent: Wednesday, February 23, 2011 9:10 AM > To: Hank Janssen > On Wed, 2011-02-23 at 16:58 +0000, Hank Janssen wrote: > > > #define pr_fmt(fmt) "%s: " fmt, VMBUS_MOD > > > or > > > #define pr_fmt(fmt) "%s:%s " fmt, VMBUS_MOD, __func__ > > > (if you must) > > I wrestled with that when I did the conversion, The reason I did not > > Do that is when I check other drivers very few do it that way, most > do > > It the way I do it or actually hard code the module name to be > printed. > > My preference would have been to use the KBUILD_MODNAME that > almost every other driver/module uses. > > > So what is the general consensus. The current way I implemented it > seems > > to be how other drivers use it to. > > Your code, your choices.
Joe, Hey I am easy! I am just not cheap! :) Based on your feedback and Dan Carpenter's feedback I will implement It the way you suggested it. I should have the patch out later today. Hank. _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
