On Wed, Feb 23, 2011 at 09:24:45PM +0100, Arend van Spriel wrote:
> >wl isn't used any more. It causes a compile warning.
> >
> >drivers/staging/brcm80211/brcmsmac/wl_mac80211.c: In function
> >‘wl_ops_stop’:
> >drivers/staging/brcm80211/brcmsmac/wl_mac80211.c:186: warning:
> >unused variable ‘wl’
> >
> >> ASSERT(wl);
>
> It is actually used in the statement above but only when CONFIG_BRCMDBG=y.
>
Yeah. We should delete the assert statement too because that's the
easiest way to get rid of the warning.
> >>@@ -1988,8 +1985,10 @@ bool wl_rfkill_set_hw_state(struct wl_info *wl)
> >>
> >> WL_NONE("%s: update hw state: blocked=%s\n", __func__,
> >> blocked ? "true" : "false");
> >>+ WL_UNLOCK(wl);
> >
> >This is called from wlc_dpc() without the lock held, so the unlock here
> >doesn't seem right. What's this lock protecting here anyway?
> >
>
> Actually, wlc_dpc() is called from wl_dpc() which holds the lock.
Ah. You're right. Sorry for that.
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
