On Thu, Mar 10, 2011 at 11:02:46PM +0200, Aaro Koskinen wrote:
> Rename XGINew_SetRegANDOR() to xgifb_reg_and_or().
> 
> Signed-off-by: Aaro Koskinen <[email protected]>
> ---

> -void XGINew_SetRegANDOR(unsigned long Port, unsigned short Index,
> -             unsigned short DataAND, unsigned short DataOR)
> +void xgifb_reg_and_or(unsigned long port, u8 index, unsigned data_and,
                                             ^^^^^^^^  ^^^^^^^^^^^^^^^^^
> +                   unsigned data_or)
                      ^^^^^^^^^^^^^^^^
I wish the change log had mentioned some of these data type changes.  It
doesn't cause a bug, but it still should have been mentioned.

>  {
> -     unsigned short temp;
> +     u8 temp;

regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to