On Tue, 2011-04-19 at 09:13 +0200, Roland Vossen wrote: > Code cleanup. __mips__ was undefined for current builds. > > Signed-off-by: Roland Vossen <[email protected]> > Reviewed-by: Arend van Spriel <[email protected]> > --- > .../staging/brcm80211/brcmsmac/phy/wlc_phy_cmn.c | 48 > -------------------- > drivers/staging/brcm80211/include/bcmdefs.h | 4 -- > drivers/staging/brcm80211/include/bcmutils.h | 31 ------------- > drivers/staging/brcm80211/util/bcmutils.c | 28 ----------- > drivers/staging/brcm80211/util/hnddma.c | 23 --------- > 5 files changed, 0 insertions(+), 134 deletions(-) > > diff --git a/drivers/staging/brcm80211/brcmsmac/phy/wlc_phy_cmn.c > b/drivers/staging/brcm80211/brcmsmac/phy/wlc_phy_cmn.c > index 40f0444..92133c7 100644 > --- a/drivers/staging/brcm80211/brcmsmac/phy/wlc_phy_cmn.c > +++ b/drivers/staging/brcm80211/brcmsmac/phy/wlc_phy_cmn.c > @@ -246,15 +246,9 @@ u16 read_radio_reg(phy_info_t *pi, u16 addr) > (D11REV_IS(pi->sh->corerev, 22) > && (pi->pubpi.phy_type != PHY_TYPE_SSN))) { > W_REG(&pi->regs->radioregaddr, addr); > -#ifdef __mips__ > - (void)R_REG(&pi->regs->radioregaddr); > -#endif
Are you sure? __mips__ is automagically defined by GCC, if compiling for MIPS. Maybe it should be converted to some CONFIG_... symbol. But removal seems wrong. -- Greetings Michael. _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
