On Tue, May 10, 2011 at 07:54:17AM -0700, K. Y. Srinivasan wrote: > The subject line says it all. > > Signed-off-by: K. Y. Srinivasan <[email protected]> > Signed-off-by: Haiyang Zhang <[email protected]> > Signed-off-by: Abhishek Kane <[email protected]> > Signed-off-by: Hank Janssen <[email protected]> > --- > drivers/staging/hv/storvsc.c | 116 > ++++++------------------------------------ > 1 files changed, 16 insertions(+), 100 deletions(-) > > diff --git a/drivers/staging/hv/storvsc.c b/drivers/staging/hv/storvsc.c > index 5d5aec3..41361f5 100644 > --- a/drivers/staging/hv/storvsc.c > +++ b/drivers/staging/hv/storvsc.c > @@ -113,11 +113,8 @@ static int storvsc_channel_init(struct hv_device *device) > int ret, t; > > stor_device = get_stor_device(device); > - if (!stor_device) { > - DPRINT_ERR(STORVSC, "unable to get stor device..." > - "device being destroyed?"); > + if (!stor_device) > return -1;
Just a note for future things to clean up. Never return -1, please use proper -ERR* values instead. thanks, greg k-h _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
