On Mon, 2011-06-13 at 23:29 +0200, Németh Márton wrote: > From: Márton Németh <[email protected]> > > The wIndex parameter of vhci_hub_control() is always zero when the > request type is GetHubDescriptor, > --- > diff --git a/drivers/staging/usbip/vhci_hcd.c > b/drivers/staging/usbip/vhci_hcd.c > @@ -464,8 +464,11 @@ static int vhci_hub_control(struct usb_hcd *hcd, u16 > typeReq, u16 wValue, > > if (usbip_dbg_flag_vhci_rh) { > pr_debug("port %d\n", rhport); > - dump_port_status(prev_port_status[rhport]); > - dump_port_status(dum->port_status[rhport]); > + /* Only dump valid port status */ > + if (0 <= rhport) { > + dump_port_status(prev_port_status[rhport]); > + dump_port_status(dum->port_status[rhport]); > + } > } > usbip_dbg_vhci_rh(" bye\n"); >
Linux relatively rarely uses constant before variable in a comparison. ie: please use "if (rhport > 0)" instead _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
