Use standard Linux error codes.

Signed-off-by: K. Y. Srinivasan <[email protected]>
Signed-off-by: Haiyang Zhang <[email protected]>
Signed-off-by: Hank Janssen <[email protected]>
---
 drivers/staging/hv/netvsc.c |   10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/hv/netvsc.c b/drivers/staging/hv/netvsc.c
index b640e08..1bca667 100644
--- a/drivers/staging/hv/netvsc.c
+++ b/drivers/staging/hv/netvsc.c
@@ -323,7 +323,7 @@ static int netvsc_connect_vsp(struct hv_device *device)
        if (!net_device) {
                dev_err(&device->device, "unable to get net device..."
                           "device being destroyed?");
-               return -1;
+               return -ENODEV;
        }
 
        init_packet = &net_device->channel_init_pkt;
@@ -354,13 +354,13 @@ static int netvsc_connect_vsp(struct hv_device *device)
 
        if (init_packet->msg.init_msg.init_complete.status !=
            NVSP_STAT_SUCCESS) {
-               ret = -1;
+               ret = -EINVAL;
                goto cleanup;
        }
 
        if (init_packet->msg.init_msg.init_complete.
            negotiated_protocol_ver != NVSP_PROTOCOL_VERSION_1) {
-               ret = -1;
+               ret = -EPROTO;
                goto cleanup;
        }
        /* Send the ndis version */
@@ -381,10 +381,8 @@ static int netvsc_connect_vsp(struct hv_device *device)
                                sizeof(struct nvsp_message),
                                (unsigned long)init_packet,
                                VM_PKT_DATA_INBAND, 0);
-       if (ret != 0) {
-               ret = -1;
+       if (ret != 0)
                goto cleanup;
-       }
 
        /* Post the big receive buffer to NetVSP */
        ret = netvsc_init_recv_buf(device);
-- 
1.7.4.1

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to