On Thu, Jun 23, 2011 at 13:45, Ralf Baechle <[email protected]> wrote: > On architectures that don't define PAGE_KERNEL_NOCACHE, the Comedi driver > turns > into tragedy: > > CC [M] drivers/staging/comedi/drivers.o > drivers/staging/comedi/drivers.c: In function ‘comedi_buf_alloc’: > drivers/staging/comedi/drivers.c:505:41: error: ‘PAGE_KERNEL_NOCACHE’ > undeclared (first use in this function) > drivers/staging/comedi/drivers.c:505:41: note: each undeclared identifier is > rep orted only once for each function it appears in > make[3]: *** [drivers/staging/comedi/drivers.o] Error 1 > > Restrict the driver to only those architectures that define > PAGE_KERNEL_NOCACHE. > > PAGE_KERNEL_NOCACHE is a kludge - some system architectures such as SGI IP27 > are even uable to offer uncached operation - at least in the way an unwitting > driver might assume. I haven't looked in details how the driver is using > the area vmaped with PAGE_KERNEL_NOCACHE but maybe doing it XFS-style using > cached memory and the flush_kernel_vmap_range / invalidate_kernel_vmap_range > APIs in conjunction with the DMA API is a practical alternative. > > Signed-off-by: Ralf Baechle <[email protected]>
Acked-by: Geert Uytterhoeven <[email protected]> If only to get m68k/allmodconfig going again (hmm, there's another staging driver preventing a green light). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
