On Thu, Jul 14, 2011 at 02:29:31PM -0700, Franky Lin wrote:
> --- a/drivers/staging/brcm80211/brcmfmac/dhd_common.c
> +++ b/drivers/staging/brcm80211/brcmfmac/dhd_common.c
> @@ -827,10 +827,13 @@ static int brcmf_c_pattern_atoh(char *src, char *dst)
>               return -EINVAL;
>       }
>       for (i = 0; *src != '\0'; i++) {
> +             unsigned long res;
>               char num[3];
>               strncpy(num, src, 2);
>               num[2] = '\0';
> -             dst[i] = (u8) simple_strtoul(num, NULL, 16);
> +             if (kstrtoul(num, 16, &res))
> +                     return -1;
                               ^^
Not a proper error code.

> +             dst[i] = (u8)res;
>               src += 2;

regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to