On Mon, Aug 01, 2011 at 12:20:48PM +0200, Manohar Vanga wrote:
>       if (bridge->parent == NULL) {
>               printk(KERN_ERR "Dev entry NULL\n");

The user wouldn't know which driver is printing the error.

>               return NULL;
>       }
> -     pdev = container_of(bridge->parent, struct pci_dev, dev);
>  
> -     return pci_alloc_consistent(pdev, size, dma);
> +     if (bridge->alloc_consistent == NULL) {
> +             printk(KERN_ERR "alloc_consistent not supported by bridge\n");

Could probably be improved as well.

> +             return NULL;
> +     }
> +

regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to