On Tue, Aug 23, 2011 at 11:40:17AM -0500, Larry Finger wrote:
> On 08/23/2011 11:15 AM, Ali Bahar wrote:
> >Hi Larry,
> >
> >
> >On Tue, Aug 23, 2011 at 10:38:57AM -0500, Larry Finger wrote:
> >>On 08/23/2011 12:53 AM, Ali Bahar wrote:
> >>>--- a/drivers/staging/rtl8712/rtl8712_recv.h
> >>>+++ b/drivers/staging/rtl8712/rtl8712_recv.h
> >>> union {
> >>> struct list_head list;
> >>> struct recv_frame_hdr hdr;
> >>>- addr_t mem[RECVFRAME_HDR_ALIGN>>2];
> >>>+ uint mem[RECVFRAME_HDR_ALIGN>>2];
> >>
> >>Does this work with 64-bit systems? I have not tested, but changing
> >>from addr_t to uint looks wrong.
> >
> >Yeah, I spent a fair bit of time looking at this, back then.
> >The key point is that 'mem' is not used anymore! The function which
> >used it, mp_ioctl_xmit_packet_hdl, has been gutted.
> >
> >That aside, I checked it for size; but .hdr is still its biggest
> >member. So the size has not been affected.
> >And I did not think of any unorthodox manipulations of the other
> >members which may choke on this change. So I did not go thru all the
>
> OK, but if mem is not used anymore. should it be deleted?
If you guys know that all access to this union is conventional, then
_yes_ it should be.
... I'll mark it for deletion.
thanks,
ali
> Larry
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
