On Wed, Aug 31, 2011 at 07:52:24PM +0300, Dan Carpenter wrote:
> On Wed, Aug 31, 2011 at 04:42:41PM +0300, Oren Weil wrote:
> > +static int mei_wd_ops_ping(struct watchdog_device *wd_dev)
> > +{
> > + int ret = 0;
> > + struct mei_device *dev;
> > + dev = pci_get_drvdata(mei_device);
> > +
> > + if (!dev)
> > + return -ENODEV;
> > +
> > + mutex_lock(&dev->device_lock);
> > +
> > + if (dev->wd_cl.state != MEI_FILE_CONNECTED) {
> > + dev_dbg(&dev->pdev->dev, "wd is not connected.\n");
> > + ret = -ENODEV;
> > + goto end;
> > + }
> > +
> > + /* Check if we can send the ping to HW*/
> > + if (dev->mei_host_buffer_is_empty &&
> > + mei_flow_ctrl_creds(dev, &dev->wd_cl) > 0) {
> > + dev->mei_host_buffer_is_empty = false;
> ^^^^^^^^^^^^^^^^
>
> This is a two tab indent. Don't do that.
Yeah, that's odd.
Oren, care to redo this patch and resend the whole series?
thanks,
greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
