On Wed, Sep 21, 2011 at 04:45:31PM +0300, Oren Weil wrote:
> Acked-by: Tomas Winkler <[email protected]>
> Signed-off-by: Oren Weil <[email protected]>
> ---
>  drivers/staging/mei/TODO |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/mei/TODO b/drivers/staging/mei/TODO
> index 3b6a667..7d9a13b 100644
> --- a/drivers/staging/mei/TODO
> +++ b/drivers/staging/mei/TODO
> @@ -1,14 +1,4 @@
>  TODO:
> -     - Create in-kernel Client API. Examples of in-kernel clients are 
> watchdog and AMTHI.

Did you really do this?

> -     - ME Watchdog Driver to expose standard Linux watchdog interface

And this?

> -     - Rewrite AMTHI to use in-kernel client interface

And this?

> -     - Cleanup init and probe functions
> -     - Review BUG/BUG_ON usage
> -     - Cleanup and reorganize header files
> -     - Rewrite client data structure

And this?

> -     - Make state machine more readable
> -     - Add mei.txt with driver explanation and it's driver

You really don't describe the kernel/user api here, that needs to be
well documented as it is a ABI you are creating and we need to know how
it works.

thanks,

greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to