On Fri, Sep 23, 2011 at 07:09:04PM -0700, Franky Lin wrote: > From: Roland Vossen <[email protected]> > > Global variables are undesirable unless they are read only. > > Reported-by: Johannes Berg <[email protected]> > Reviewed-by: Pieter-Paul Giesberts <[email protected]> > Reviewed-by: Arend van Spriel <[email protected]> > Signed-off-by: Franky Lin <[email protected]> > --- > diff --git a/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c > b/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c > index 15c5ffc..1b11b2f 100644 > --- a/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c > +++ b/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c > @@ -1611,7 +1611,7 @@ const u32 dot11lcnphytbl_rx_gain_info_sz_rev0 = > sizeof(dot11lcnphytbl_rx_gain_info_rev0) / > sizeof(dot11lcnphytbl_rx_gain_info_rev0[0]); > > -static const u32 dot11lcnphytbl_rx_gain_info_sz_rev1 = > +const u32 dot11lcnphytbl_rx_gain_info_sz_rev1 = > sizeof(dot11lcnphytbl_rx_gain_info_rev1) / > sizeof(dot11lcnphytbl_rx_gain_info_rev1[0]);
That seems like an anomaly. In a commit that is supposed to declare variables as const, the linkage of a variable changed. Likewise, the removal of extern global variable declarations in phy_int.h also does not seem to belong here. -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/. _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
