On 09/26/2011 11:06 PM, Rafał Miłecki wrote:
2011/9/24 Franky Lin<[email protected]>:
@@ -1392,20 +1407,21 @@ struct d11rxhdr {
        u16 RxStatus2;
        u16 RxTSFTime;
        u16 RxChan;
-} __packed;
+};
Is this on purpose? Is this safe?

Hi Rafał,

This is indeed on purpose as this structure is aligned (no gaps) properly because the members are all u16 and not going over the host bus. However, it is used in a union with the little-endian version which is packed. Based on feedback regarding that union this patch needs some rework so it will be resend.

Gr. AvS

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to