On 11-09-29 10:34 PM, Vinod Koul wrote: > On Fri, 2011-09-30 at 10:35 +0800, Lu Guanqun wrote: >> include module.h to fix the following compile errors: >> >> drivers/staging/intel_sst/intelmid.c:52: error: expected declaration >> specifiers or '...' before string constant >> drivers/staging/intel_sst/intelmid.c:52: warning: data definition has no >> type or storage class >> drivers/staging/intel_sst/intelmid.c:52: warning: type defaults to 'int' in >> declaration of 'MODULE_AUTHOR' >> drivers/staging/intel_sst/intelmid.c:52: warning: function declaration isn't >> a prototype >> drivers/staging/intel_sst/intelmid.c:53: error: expected declaration >> specifiers or '...' before string constant >> drivers/staging/intel_sst/intelmid.c:53: warning: data definition has no >> type or storage class >> drivers/staging/intel_sst/intelmid.c:53: warning: type defaults to 'int' in >> declaration of 'MODULE_AUTHOR' >> drivers/staging/intel_sst/intelmid.c:53: warning: function declaration isn't >> a prototype >> drivers/staging/intel_sst/intelmid.c:54: error: expected declaration >> specifiers or '...' before string constant >> drivers/staging/intel_sst/intelmid.c:54: warning: data definition has no >> type or storage class >> drivers/staging/intel_sst/intelmid.c:54: warning: type defaults to 'int' in >> declaration of 'MODULE_AUTHOR' >> drivers/staging/intel_sst/intelmid.c:54: warning: function declaration isn't >> a prototype >> drivers/staging/intel_sst/intelmid.c:55: error: expected declaration >> specifiers or '...' before string constant >> drivers/staging/intel_sst/intelmid.c:55: warning: data definition has no >> type or storage class >> drivers/staging/intel_sst/intelmid.c:55: warning: type defaults to 'int' in >> declaration of 'MODULE_AUTHOR' >> drivers/staging/intel_sst/intelmid.c:55: warning: function declaration isn't >> a prototype >> drivers/staging/intel_sst/intelmid.c:56: error: expected declaration >> specifiers or '...' before string constant >> drivers/staging/intel_sst/intelmid.c:56: warning: data definition has no >> type or storage class >> drivers/staging/intel_sst/intelmid.c:56: warning: type defaults to 'int' in >> declaration of 'MODULE_DESCRIPTION' >> drivers/staging/intel_sst/intelmid.c:56: warning: function declaration isn't >> a prototype >> drivers/staging/intel_sst/intelmid.c:57: error: expected declaration >> specifiers or '...' before string constant >> drivers/staging/intel_sst/intelmid.c:57: warning: data definition has no >> type or storage class >> drivers/staging/intel_sst/intelmid.c:57: warning: type defaults to 'int' in >> declaration of 'MODULE_LICENSE' >> drivers/staging/intel_sst/intelmid.c:57: warning: function declaration isn't >> a prototype >> drivers/staging/intel_sst/intelmid.c:58: error: expected declaration >> specifiers or '...' before string constant >> drivers/staging/intel_sst/intelmid.c:58: warning: data definition has no >> type or storage class >> drivers/staging/intel_sst/intelmid.c:58: warning: type defaults to 'int' in >> declaration of 'MODULE_SUPPORTED_DEVICE' >> drivers/staging/intel_sst/intelmid.c:58: warning: function declaration isn't >> a prototype >> drivers/staging/intel_sst/intelmid.c:64: error: expected ')' before 'int' >> drivers/staging/intel_sst/intelmid.c:65: error: expected ')' before string >> constant >> drivers/staging/intel_sst/intelmid.c:66: error: expected ')' before numeric >> constant >> drivers/staging/intel_sst/intelmid.c:67: error: expected ')' before string >> constant >> drivers/staging/intel_sst/intelmid.c:461: warning: data definition has no >> type or storage class >> drivers/staging/intel_sst/intelmid.c:461: warning: type defaults to 'int' in >> declaration of 'EXPORT_SYMBOL_GPL' >> drivers/staging/intel_sst/intelmid.c:461: warning: parameter names (without >> types) in function declaration >> drivers/staging/intel_sst/intelmid.c:475: warning: data definition has no >> type or storage class >> drivers/staging/intel_sst/intelmid.c:475: warning: type defaults to 'int' in >> declaration of 'EXPORT_SYMBOL_GPL' >> drivers/staging/intel_sst/intelmid.c:475: warning: parameter names (without >> types) in function declaration >> drivers/staging/intel_sst/intelmid.c: In function 'snd_intelmad_probe': >> drivers/staging/intel_sst/intelmid.c:859: error: 'THIS_MODULE' undeclared >> (first use in this function) >> drivers/staging/intel_sst/intelmid.c:859: error: (Each undeclared identifier >> is reported only once >> drivers/staging/intel_sst/intelmid.c:859: error: for each function it >> appears in.) >> drivers/staging/intel_sst/intelmid.c: At top level: >> drivers/staging/intel_sst/intelmid.c:989: error: 'THIS_MODULE' undeclared >> here (not in a function)
A minor nit, but we probably don't need all 70 lines of the compile failure in the long log. It doesn't really add any value or information. Just a comment that the file really needs module.h since it is a module source file would suffice. Thanks, Paul. >> >> Reported-by: Stephen Rothwell <[email protected]> >> Signed-off-by: Lu Guanqun <[email protected]> >> --- >> drivers/staging/intel_sst/intelmid.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/staging/intel_sst/intelmid.c >> b/drivers/staging/intel_sst/intelmid.c >> index 25656ad..492b660 100644 >> --- a/drivers/staging/intel_sst/intelmid.c >> +++ b/drivers/staging/intel_sst/intelmid.c >> @@ -27,6 +27,7 @@ >> >> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt >> >> +#include <linux/module.h> >> #include <linux/slab.h> >> #include <linux/io.h> >> #include <linux/platform_device.h> > Thanks I was midway of creating this fix :) > > Acked-by: Vinod Koul <[email protected]> > > _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
