Hi,

On Sun, 9 Oct 2011, Dan Carpenter wrote:
On Sun, Oct 09, 2011 at 07:42:51PM +0300, Aaro Koskinen wrote:
-       switch (xgi_video_info.disp_state & DISPTYPE_DISP2) {
+       switch (xgifb_info->disp_state & DISPTYPE_DISP2) {

This isn't related to this patch, but this data type is weird.

It would be probably be more natural to break up ->disp_state into
two variables where one stored the display type and one stored the if
the displays were mirrored or single.  Can you connect a CRT and an
LCD at the same time?

Based on a quick look, the driver does not even use the single/mirror
info for anything...

It should be possible to connect CRT+LCD at the same time.

A.
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to