2011/10/2 Franky Lin <[email protected]>: > From: Roland Vossen <[email protected]> > > So it is clear to the reader what memory is IO mapped > > Reviewed-by: Pieter-Paul Giesberts <[email protected]> > Reviewed-by: Arend van Spriel <[email protected]> > Signed-off-by: Franky Lin <[email protected]> > --- > drivers/staging/brcm80211/brcmsmac/aiutils.c | 107 > ++++++++++++++------------ > drivers/staging/brcm80211/brcmsmac/aiutils.h | 16 ++-- > drivers/staging/brcm80211/brcmsmac/main.c | 2 +- > drivers/staging/brcm80211/brcmsmac/nicpci.c | 45 ++++++----- > drivers/staging/brcm80211/brcmsmac/nicpci.h | 9 +- > drivers/staging/brcm80211/brcmsmac/otp.c | 9 +- > drivers/staging/brcm80211/brcmsmac/pmu.c | 16 ++-- > drivers/staging/brcm80211/brcmsmac/srom.c | 20 +++-- > drivers/staging/brcm80211/brcmsmac/srom.h | 2 +- > 9 files changed, 123 insertions(+), 103 deletions(-) > > diff --git a/drivers/staging/brcm80211/brcmsmac/aiutils.c > b/drivers/staging/brcm80211/brcmsmac/aiutils.c > index 790fdce..0b3ba6a 100644 > --- a/drivers/staging/brcm80211/brcmsmac/aiutils.c > +++ b/drivers/staging/brcm80211/brcmsmac/aiutils.c > @@ -323,7 +323,8 @@ > (((si)->pub.buscoretype == PCI_CORE_ID) && \ > (si)->pub.buscorerev >= 13)) > > -#define CCREGS_FAST(si) (((char *)((si)->curmap) + PCI_16KB0_CCREGS_OFFSET)) > +#define CCREGS_FAST(si) (((char __iomem *)((si)->curmap) + \ > + PCI_16KB0_CCREGS_OFFSET))
I've a question (not to just you), should we prefer u8/u16/u32 types in code? If so, you could think to changing this since you already touch this code. -- Rafał _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
