On Mon, Oct 03, 2011 at 07:18:12PM +0530, Ravishankar Karkala Mallikarjunayya wrote: > This is a patch to the cb_pcidda.c file that fixes up a printk warning found > by the checkpatch.pl tool > > Signed-off-by: Ravishankar Karkala Mallikarjunayya > <[email protected]> > --- > I was not mentioned printk("eeprom:") and > printk(" %i:0x%x ", index, devpriv->eeprom_data[index]); line in Earlier > patch which is fixed. > > drivers/staging/comedi/drivers/cb_pcidda.c | 25 ++++++++++++++----------- > 1 files changed, 14 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/cb_pcidda.c > b/drivers/staging/comedi/drivers/cb_pcidda.c > index 49102b3..da5b8e5 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidda.c > +++ b/drivers/staging/comedi/drivers/cb_pcidda.c > @@ -282,7 +282,8 @@ static int cb_pcidda_attach(struct comedi_device *dev, > struct pci_dev *pcidev = NULL; > int index; > > - printk("comedi%d: cb_pcidda: ", dev->minor); > + dev_info(&pcidev->dev, "comedi%d: cb_pcidda:\n", > + dev->minor); > > /* > * Allocate the private structure area. > @@ -293,7 +294,6 @@ static int cb_pcidda_attach(struct comedi_device *dev, > /* > * Probe the device to determine what device in the series it is. > */ > - printk("\n"); > > for_each_pci_dev(pcidev) { > if (pcidev->vendor == PCI_VENDOR_ID_CB) { > @@ -312,22 +312,24 @@ static int cb_pcidda_attach(struct comedi_device *dev, > } > } > if (!pcidev) { > - printk > - ("Not a ComputerBoards/MeasurementComputing card on > requested position\n"); > + dev_err(&pcidev->dev, "Not a " > + "ComputerBoards/MeasurementComputing " > + "card on requested position\n");
Please don't break strings across lines like this, just put them all on one line. greg k-h _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
