On Tue, Oct 18, 2011 at 5:10 AM, Piotr Chmura <[email protected]> wrote: > Thanks for comments for all of you. > > [PATCH 1-12/14] Following your guidelines i exported all changes from hg one > by one. This way we will have all history in kernel tree. > I moved driver to staging/media and removed Kconfig/Makefile changes in > parent directory in first patch.
Hello Piotr, Not that I want to create more work for you, but it would appear that your patches stripped off all the Signed-off-by lines for both myself and Pierrick Hascoet (the developer from the hardware vendor). You have replaced them with "cc:" lines, which breaks the chain of "Developer's Certificate of Origin". When you take somebody else's patches, you need to preserve any existing Signed-off-by lines, adding your own at the bottom of the list. In other words, the first patch should be: Signed-off-by: Pierrick Hascoet <[email protected]> Signed-off-by: Devin Heitmueller <[email protected]> Signed-off-by: Piotr Chmura <[email protected]> instead of: Signed-off-by: Piotr Chmura <[email protected]> Cc: Pierrick Hascoet <[email protected]> Cc: Devin Heitmueller <[email protected]> Devin -- Devin J. Heitmueller - Kernel Labs http://www.kernellabs.com _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
