On Fri, Oct 28, 2011 at 08:05:52PM -0500, Larry Finger wrote: > I believe it is. It probably does not matter as I have never hit an > oops at this location. >
You would only hit an Oops if you used a zero mac address for pnetwork->MacAddress. Julia's patch is turning on some code that was never tested to make it the common case. So it will be easy to see if it works or not when it gets merged. ;P To me it could go either way, (the test is reversed or the memcpy() could be removed). regards, dan carpenter _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
