On 10/29/2011 09:20 AM, Dan Carpenter wrote: > regulator_get_voltage() returns an int so "scale_uv" should be an > int. Making it unsigned here breaks the error handling. > > Signed-off-by: Dan Carpenter <[email protected]>
uhm, yes... Acked-by: Lars-Peter Clausen <[email protected]> Thanks. > > diff --git a/drivers/staging/iio/dac/ad5064.c > b/drivers/staging/iio/dac/ad5064.c > index 24279f2..3b14526 100644 > --- a/drivers/staging/iio/dac/ad5064.c > +++ b/drivers/staging/iio/dac/ad5064.c > @@ -280,8 +280,8 @@ static int ad5064_read_raw(struct iio_dev *indio_dev, > long m) > { > struct ad5064_state *st = iio_priv(indio_dev); > - unsigned long scale_uv; > unsigned int vref; > + int scale_uv; > > switch (m) { > case 0: _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
