From: Thomas Meyer <[email protected]> Use kmemdup rather than duplicating its implementation
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Thomas Meyer <[email protected]> --- diff -u -p a/drivers/staging/line6/midi.c b/drivers/staging/line6/midi.c --- a/drivers/staging/line6/midi.c 2011-11-07 19:38:11.240305613 +0100 +++ b/drivers/staging/line6/midi.c 2011-11-08 10:52:27.890730177 +0100 @@ -135,7 +135,7 @@ static int send_midi_async(struct usb_li line6_write_hexdump(line6, 'S', data, length); #endif - transfer_buffer = kmalloc(length, GFP_ATOMIC); + transfer_buffer = kmemdup(data, length, GFP_ATOMIC); if (transfer_buffer == NULL) { usb_free_urb(urb); @@ -143,7 +143,6 @@ static int send_midi_async(struct usb_li return -ENOMEM; } - memcpy(transfer_buffer, data, length); usb_fill_int_urb(urb, line6->usbdev, usb_sndbulkpipe(line6->usbdev, line6->ep_control_write), _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
