On 11/13/2011 01:05 PM, Paul Bolle wrote:
> Commit e6477000fc ("staging:iio:dummy Add event support + fake event
> generator") added "select IIO_SIMPLE_DUMMY_EVGEN if [...]". But there
> is no Kconfig symbol named IIO_SIMPLE_DUMMY_EVGEN. The select statement
> for that symbol is a nop. Drop it.
Yes, you are quite right. Looks like some dead logic from an earlier
version. My mistake.
>
> Signed-off-by: Paul Bolle <[email protected]>
Acked-by: Jonathan Cameron <[email protected]>
> ---
> 0) Tested with "make menuconfig" before and after applying this patch.
> Identical .config files were generated, as was expected.
>
> 1) The "select IIO_DUMMY_EVGEN" of the IIO_SIMPLE_DUMMY_EVENTS Kconfig
> entry probably does what was intended here. Maybe that's why no one
> noticed.
Indeed it does.
>
> drivers/staging/iio/Kconfig | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
> index 4ec9118..90162aa 100644
> --- a/drivers/staging/iio/Kconfig
> +++ b/drivers/staging/iio/Kconfig
> @@ -76,7 +76,6 @@ config IIO_DUMMY_EVGEN
>
> config IIO_SIMPLE_DUMMY
> tristate "An example driver with no hardware requirements"
> - select IIO_SIMPLE_DUMMY_EVGEN if IIO_SIMPLE_DUMMY_EVENTS
> help
> Driver intended mainly as documentation for how to write
> a driver. May also be useful for testing userspace code
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
