On Fri, Feb 10, 2012 at 07:14:59PM +0100, Lars-Peter Clausen wrote: > We call this field "chan" throughout IIO with the exception of this one macro. > Rename it to be more consistent. > > Signed-off-by: Lars-Peter Clausen <[email protected]> > Acked-by: Jonathan Cameron <[email protected]> > --- > drivers/staging/iio/events.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/staging/iio/events.h b/drivers/staging/iio/events.h > index bfb6340..416800e 100644 > --- a/drivers/staging/iio/events.h > +++ b/drivers/staging/iio/events.h > @@ -96,7 +96,7 @@ enum iio_event_direction { > > /* Event code number extraction depends on which type of event we have. > * Perhaps review this function in the future*/ > -#define IIO_EVENT_CODE_EXTRACT_NUM(mask) ((__s16)(mask & 0xFFFF)) > +#define IIO_EVENT_CODE_EXTRACT_CHAN(mask) ((__s16)(mask & 0xFFFF))
Nice, but then you just broke the build: drivers/staging/iio/adc/ad799x_core.c: In function ‘ad799x_write_event_value’: drivers/staging/iio/adc/ad799x_core.c:259:2: error: implicit declaration of function ‘IIO_EVENT_CODE_EXTRACT_NUM’ [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors Please be more careful when sending patches, I've dropped all 4 of these... greg k-h _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
