Thank you, Dan, for your comments.
> > +/*
> > + Usage example through board-setup.
> > +static const struct ad7739_platform_data dd11_adc =.{
> ^
> Remove the typo extra period.
Other driver headers in include/linux/platform_data use the form
MY_DRIVER_NAME_platform_data, so in my opinion, it is best to stay as they are.
> > +
> > + if (alloc_private(dev, sizeof(struct ad7739_private)) < 0)
> > + return -ENOMEM;
>
> ret = alloc_private(dev, sizeof(struct ad7739_private));
> if (ret)
> return ret;
Thank you, I've investigated other comedi drivers, some of them use such
handling for comedi specific functions
if (ret < 0)
return ret;
so, in my point of view, it is best to use generally accepted way in
comedi_lib, thank you for pointing that out.
All other comments have apllied as is.
--
Best regards,
Alexander Pazdnikov
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
