On Wed, Apr 11, 2012 at 06:46:33PM -0400, Xi Wang wrote:
> On Apr 11, 2012, at 6:35 PM, Jesper Juhl wrote:
> 
> > -           pNodeList = (PSNodeList)kmalloc(sizeof(SNodeList) + 
> > (sNodeList.uItem * sizeof(SNodeItem)), (int)GFP_ATOMIC);
> > +           pNodeList = kmalloc(sizeof(SNodeList) + (sNodeList.uItem * 
> > sizeof(SNodeItem)), (int)GFP_ATOMIC);
> 
> Can you also remove casts like "(int)GFP_ATOMIC"?
> 
> The parentheses "(sNodeList.uItem * sizeof(SNodeItem))" are also
> pointless..

One thing at a time, odds are this is an "automated" patch, right
Jesper?

thanks,

greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to