On Tue, Apr 24, 2012 at 09:27:09PM +0200, Stéphane Pajot wrote: > On Tue, Apr 24, 2012 at 11:46:42AM -0700, Greg KH wrote: > > On Tue, Apr 24, 2012 at 06:50:10PM +0200, Stéphane Pajot wrote: > > > @@ -738,7 +738,7 @@ static int labpc_attach(struct comedi_device *dev, > > > struct comedi_devconfig *it) > > > irq = it->options[1]; > > > dma_chan = it->options[2]; > > > #else > > > - printk(KERN_ERR " this driver has not been built with ISA DMA " > > > + printk(KERN_ERR " this driver has not been built with ISA DMA\n" > > > "support.\n"); > > > > What? Why did you do this? Do you understand what you just did to the > > message printed out? > > ... It was just to patch this "quoted string split across lines > warning", i saw this solution on the web. Now i think i understand that > i cannot modify AT ALL a printk(KERN_ERR* even if it's just with a \n ?
Think about what is actually happening here. You do know C, right? What is the output of the line before you made the change, and now after? thanks, greg k-h _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
