On Wed, May 16, 2012 at 3:11 PM, Anton Vorontsov <[email protected]> wrote: > On Wed, May 16, 2012 at 10:56:09AM -0700, Colin Cross wrote: > [...] >> > +You can specify either RAM memory or peripheral devices' memory. However, >> > when >> > +specifying RAM, be sure to reserve the memory by issuing >> > memblock_reserve() >> > +very early in the architecture code, just before platform device >> > registration, >> >> Just before platform device registration is way too late. ARM >> provides a machine reserve callback to allow board files to call >> memblock_reserve inside arm_memblock_init() and before mm_init(). > > Yeah, and I guess that 'too late' is also true for all architectures, > the platform_device_register and friends are most probably unusable > before mm_init, and after that it's always too late. > > So the word 'just' is misleading indeed, I'll remove it.
I think any reference to the time when platform devices are registered is misleading. There is a very specific point during arch init where memblock_reserve is valid, and it is nowhere near platform device registration. _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
