The source code defines a macro NULLFUNC

  #define NULLFUNC 0

and uses it as a generic null function pointer constant.  This is
superfluous.  Just use NULL instead.

Signed-off-by: Ian Abbott <[email protected]>
---
 drivers/staging/comedi/drivers/amplc_pci230.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c 
b/drivers/staging/comedi/drivers/amplc_pci230.c
index 30487be..3a38dc7 100644
--- a/drivers/staging/comedi/drivers/amplc_pci230.c
+++ b/drivers/staging/comedi/drivers/amplc_pci230.c
@@ -430,9 +430,6 @@ enum {
 /* Combine old and new bits. */
 #define COMBINE(old, new, mask)        (((old) & ~(mask)) | ((new) & (mask)))
 
-/* A generic null function pointer value.  */
-#define NULLFUNC       0
-
 /* Current CPU.  XXX should this be hard_smp_processor_id()? */
 #define THISCPU                smp_processor_id()
 
@@ -1489,7 +1486,7 @@ static int pci230_ao_inttrig_start(struct comedi_device 
*dev,
        if (trig_num != 0)
                return -EINVAL;
 
-       s->async->inttrig = NULLFUNC;
+       s->async->inttrig = NULL;
        pci230_ao_start(dev, s);
 
        return 1;
@@ -2290,7 +2287,7 @@ static int pci230_ai_inttrig_start(struct comedi_device 
*dev,
        if (trig_num != 0)
                return -EINVAL;
 
-       s->async->inttrig = NULLFUNC;
+       s->async->inttrig = NULL;
        pci230_ai_start(dev, s);
 
        return 1;
-- 
1.7.8.6

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to