On Sun, Jun 17, 2012 at 07:17:40PM +0530, Devendra Naga wrote:
> The following warnings / errors were cleaned
>
> drivers/staging/rtl8192u/r8180_93cx6.c:25: ERROR: space required before the
> open parenthesis '('
> drivers/staging/rtl8192u/r8180_93cx6.c:28: ERROR: do not use C99 // comments
> drivers/staging/rtl8192u/r8180_93cx6.c:30: WARNING: line over 80 characters
> drivers/staging/rtl8192u/r8180_93cx6.c:31: ERROR: do not use C99 // comments
> drivers/staging/rtl8192u/r8180_93cx6.c:41: ERROR: space required after that
> ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: need consistent spacing a
> round '&' (ctx:WxO)
> drivers/staging/rtl8192u/r8180_93cx6.c:45: ERROR: space prohibited after that
> '~' (ctx:OxW)
> drivers/staging/rtl8192u/r8180_93cx6.c:51: ERROR: space required after that
> ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:53: ERROR: space required before the
> open parenthesis '('
> drivers/staging/rtl8192u/r8180_93cx6.c:55: ERROR: space required after that
> ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:57: ERROR: space required after that
> ',' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: spaces required around that
> '=' (ctx:VxV)
> drivers/staging/rtl8192u/r8180_93cx6.c:69: ERROR: space prohibited before
> that close parenthesis ')'
> drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: space required before the
> open parenthesis '('
> drivers/staging/rtl8192u/r8180_93cx6.c:72: ERROR: trailing statements should
> be on next line
>
> Signed-off-by: Devendra Naga <[email protected]>
It's good you broke this down as to what you were fixing, but I don't
like this change:
> - if(bit) return 1;
> - return 0;
> + return bit ? 1: 0;
Please don't use ? : if you can help it, it is just hard to read.
Care to redo this one and resend both patches?
thanks,
greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
