On Fri, Jun 29, 2012 at 11:05:16AM +0200, Zoltan Kelemen wrote: > On 29 jun 2012 09:24 "Dan Carpenter" <[email protected]> wrote: > > > Gar... Don't do this. :/ Each bullet point here should be a > > separate patch. Please break it apart and resend. > > I understand a large patch is harder to audit than small incremental changes, > but the patch was the result of a code rewrite, where I attempted to > summarize the changes in large in the bulleted list. There isn't a one-to-one > correspondence between a bullet and a change in the code. Breaking the > rewrite into small pieces would not only be quite hard but to some extent > even more confusing to audit since you risk to see the leaves instead of the > tree. >
We've done this before. We can help you break it apart. Step 1: Change all the existing spinlocks to spin_lock_bh(). Step 2: Do all the white space changes. Step 3: Shuffle the global variable declarations around. That's half the patch gone already. regards, dan carpenter _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
