as comedi_alloc_subdevices may fail, we leak out the memory allocated by alloc_private, and also the I/O regions we requested.
free out the private data pointer of the driver, and release the I/O regions. Signed-off-by: Devendra Naga <[email protected]> --- drivers/staging/comedi/drivers/fl512.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/fl512.c b/drivers/staging/comedi/drivers/fl512.c index 52e6d14..6538497 100644 --- a/drivers/staging/comedi/drivers/fl512.c +++ b/drivers/staging/comedi/drivers/fl512.c @@ -135,8 +135,11 @@ static int fl512_attach(struct comedi_device *dev, struct comedi_devconfig *it) #endif ret = comedi_alloc_subdevices(dev, 2); - if (ret) + if (ret) { + kfree(dev); + release_region(iobase, FL512_SIZE); return ret; + } /* * this if the definitions of the supdevices, 2 have been defined -- 1.7.9.5 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
