On Sun, Jul 22, 2012 at 10:57:09PM +0200, Jesper Juhl wrote: > Make it match CodingStyle a bit better, tab/space wise. > > Signed-off-by: Jesper Juhl <[email protected]> > --- > drivers/staging/slicoss/slic.h | 751 > ++++++++++++++++++++--------------------- > 1 file changed, 374 insertions(+), 377 deletions(-) > > diff --git a/drivers/staging/slicoss/slic.h b/drivers/staging/slicoss/slic.h > index ebdcc6f..0deb670 100644 > --- a/drivers/staging/slicoss/slic.h > +++ b/drivers/staging/slicoss/slic.h > @@ -42,61 +42,62 @@ > #define __SLIC_DRIVER_H__ > > /* firmware stuff */ > -#define OASIS_UCODE_VERS_STRING "1.2" > -#define OASIS_UCODE_VERS_DATE "2006/03/27 15:10:37" > -#define OASIS_UCODE_HOSTIF_ID 3 > +#define OASIS_UCODE_VERS_STRING "1.2" > +#define OASIS_UCODE_VERS_DATE "2006/03/27 15:10:37" > +#define OASIS_UCODE_HOSTIF_ID 3
No. The original was far better. Looking through the rest of the patch, some of these changes are ok, and some are nonsense. regards, dan carpenter _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
