On Tuesday, September 11, 2012 2:05 PM, Greg KH wrote:
> On Tue, Sep 11, 2012 at 01:54:21PM -0700, H Hartley Sweeten wrote:
>> This driver no longer walks the pci bus to find the pci_dev.
>> The pci_dev_put() is no longer needed.
>> 
>> Signed-off-by: H Hartley Sweeten <[email protected]>
>> Cc: Ian Abbott <[email protected]>
>> ---
>>  drivers/staging/comedi/drivers/adl_pci9111.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/staging/comedi/drivers/adl_pci9111.c 
>> b/drivers/staging/comedi/drivers/adl_pci9111.c
>> index d2d072e..91efaa4 100644
>> --- a/drivers/staging/comedi/drivers/adl_pci9111.c
>> +++ b/drivers/staging/comedi/drivers/adl_pci9111.c
>> @@ -970,7 +970,6 @@ static void pci9111_detach(struct comedi_device *dev)
>>      if (pcidev) {
>>              if (dev->iobase)
>>                      comedi_pci_disable(pcidev);
>> -            pci_dev_put(pcidev);
>
> Nice catch!

Thanks.

Even better if I would have removed it when I converted the
driver to the attach_pci callback....

Hartley

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to