The comedi core validates insn->n before calling this function. Remove the unnecessary check.
Signed-off-by: H Hartley Sweeten <[email protected]> Cc: Ian Abbott <[email protected]> Cc: Greg Kroah-Hartman <[email protected]> --- drivers/staging/comedi/drivers/s526.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/s526.c b/drivers/staging/comedi/drivers/s526.c index 75e3e58..f9f0fda 100644 --- a/drivers/staging/comedi/drivers/s526.c +++ b/drivers/staging/comedi/drivers/s526.c @@ -217,11 +217,6 @@ static int s526_gpct_rinsn(struct comedi_device *dev, unsigned short datalow; unsigned short datahigh; - /* Check if (n > 0) */ - if (insn->n <= 0) { - printk(KERN_ERR "s526: INSN_READ: n should be > 0\n"); - return -EINVAL; - } /* Read the low word first */ for (i = 0; i < insn->n; i++) { datalow = inw(dev->iobase + REG_C0L + counter_channel * 8); -- 1.7.11 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
