On Tuesday, October 23, 2012 9:14 PM, Fengguang Wu wrote: > Hi Hartley, > > FYI, here is a smatch warning in upstream kernel: > > + drivers/staging/comedi/drivers/cb_pcidda.c:660 cb_pcidda_attach_pci() warn: > variable dereferenced before check 'pcidev' (see line 659) > > vim +660 drivers/staging/comedi/drivers/cb_pcidda.c > > 2c0db011 H Hartley Sweeten 2012-08-16 @659 thisboard = > cb_pcidda_find_boardinfo(dev, pcidev); > 2c0db011 H Hartley Sweeten 2012-08-16 @660 if (!pcidev) > 2c0db011 H Hartley Sweeten 2012-08-16 661 return -ENODEV; > > It may want to test thisboard rather than pcidev.
Thanks for noticing this. I will post a patch shortly to fix it. Regards, Hartley _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
