On Wed, 14 Nov 2012 12:02:21 +0530 Kumar Amit Mehta <[email protected]> wrote:
> This fix adds checks for inspecting the return value of put_user() and return > -EFAULT on error. > > Signed-off-by: Kumar Amit Mehta <[email protected]> > --- > drivers/staging/dgrp/dgrp_tty.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/dgrp/dgrp_tty.c b/drivers/staging/dgrp/dgrp_tty.c > index e125b03..b294197 100644 > --- a/drivers/staging/dgrp/dgrp_tty.c > +++ b/drivers/staging/dgrp/dgrp_tty.c > @@ -2265,7 +2265,8 @@ static int get_modem_info(struct ch_struct *ch, > unsigned int *value) > | ((mlast & DM_RI) ? TIOCM_RNG : 0) > | ((mlast & DM_DSR) ? TIOCM_DSR : 0) > | ((mlast & DM_CTS) ? TIOCM_CTS : 0); > - put_user(mlast, (unsigned int __user *) value); > + if (put_user(mlast, (unsigned int __user *) value)) > + return -EFAULT; return put_user(mlast, ....) is shorter and neater and does the same thing. Alan _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
