On 3 January 2013 14:21, Dan Carpenter <[email protected]> wrote:
> On Sun, Dec 30, 2012 at 08:26:54PM +0000, [email protected] wrote:
>> @@ -881,15 +880,16 @@ static void et131x_rx_dma_disable(struct 
>> et131x_adapter *adapter)
>>  {
>>       u32 csr;
>>       /* Setup the receive dma configuration register */
>> -     writel(0x00002001, &adapter->regs->rxdma.csr);
>> +     writel(ET_RXDMA_CSR_HALT | ET_RXDMA_CSR_FBR0_ENABLE,
>> +            &adapter->regs->rxdma.csr);
>>       csr = readl(&adapter->regs->rxdma.csr);
>
> This is a behavior change.  ET_RXDMA_CSR_FBR1_ENABLE was intended
> instead of ET_RXDMA_CSR_FBR0_ENABLE.
>
>> +#define ET_RXDMA_CSR_FBR0_ENABLE     0x0400
>> +#define ET_RXDMA_CSR_FBR1_ENABLE     0x2000

Thanks Dan, well spotted. I'll send a fix for this shortly.

Greg - please drop this patchset, I'll send both as a v2.

Cheers,

Mark
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to