Due to the 'while(count < num_bytes)' the computed 'block_size' will
always be a value greater than 0.

Remove the unreachable dev_warn and the (block_size < 0) test.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Ian Abbott <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
 drivers/staging/comedi/comedi_buf.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/comedi/comedi_buf.c 
b/drivers/staging/comedi/comedi_buf.c
index 7d516a0..9d11f416 100644
--- a/drivers/staging/comedi/comedi_buf.c
+++ b/drivers/staging/comedi/comedi_buf.c
@@ -215,13 +215,6 @@ static unsigned int comedi_buf_munge(struct comedi_async 
*async,
                        int block_size = num_bytes - count;
                        unsigned int buf_end;
 
-                       if (block_size < 0) {
-                               dev_warn(s->device->class_dev,
-                                       "%s: %s: bug! block_size is negative\n",
-                                       __FILE__, __func__);
-                               break;
-                       }
-
                        buf_end = async->prealloc_bufsz - async->munge_ptr;
                        if (block_size > buf_end)
                                block_size = buf_end;
-- 
1.8.0

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to