On Tue, Feb 05, 2013 at 12:29:43AM +0100, Peter Huewe wrote:
> The XGI340_CR6B lookup table consists of the entries
> {0xaa, 0xaa, 0xaa, 0xaa} for an index <= 2 and
> {0x00, 0x00, 0x00, 0x00} for all other indices.
>
> The only user XGINew_SetDRAMDefaultRegister340 loops over these 4 values
> of a line with a for loop and since all entries are the same for each line
> we can simply replace the whole lookup table with a simple if/else assignment.
>
> Tested-by: Aaro Koskinen <[email protected]>
> Signed-off-by: Peter Huewe <[email protected]>
> ---
> drivers/staging/xgifb/vb_init.c | 2 +-
> drivers/staging/xgifb/vb_table.h | 11 -----------
> 2 files changed, 1 insertions(+), 12 deletions(-)
With this series applied, I now get the following warning when building:
driverrs/staging/xgifb/vb_init.c: In function
‘XGINew_SetDRAMDefaultRegister340’:
drivers/staging/xgifb/vb_init.c:433:43: warning: unused variable ‘i’
[-Wunused-variable]
Care to send a follow-on patch to fix this up?
thanks,
greg k-h
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
