On Fri, Feb 22, 2013 at 12:13:28PM +0100, Kurt Kanzenbach wrote:
> This patch fixes the following checkpatch error:
> -ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Kurt Kanzenbach <[email protected]>
> ---
> drivers/staging/usbip/userspace/libsrc/vhci_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/usbip/userspace/libsrc/vhci_driver.c
> b/drivers/staging/usbip/userspace/libsrc/vhci_driver.c
> index 7a5da58..b9c6e2a 100644
> --- a/drivers/staging/usbip/userspace/libsrc/vhci_driver.c
> +++ b/drivers/staging/usbip/userspace/libsrc/vhci_driver.c
> @@ -36,7 +36,7 @@ static struct usbip_imported_device
> *imported_device_init(struct usbip_imported_
> goto err;
>
> memcpy(new_cdev, cdev, sizeof(*new_cdev));
> - dlist_unshift(idev->cdev_list, (void*) new_cdev);
> + dlist_unshift(idev->cdev_list, (void *) new_cdev);
Don't resend, but there shouldn't be a space after the cast:
dlist_unshift(idev->cdev_list, (void *)new_cdev);
Cast operations have a high precedence in C and keeping things close
together makes it easier to remember. Also it looks less like a
math operations.
regards,
dan carpenter
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel