The 'default' case should never happen. In case it does, default the
gain to '1'.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Ian Abbott <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
---
 drivers/staging/comedi/drivers/dt9812.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/comedi/drivers/dt9812.c 
b/drivers/staging/comedi/drivers/dt9812.c
index 9281d49..e6d9191 100644
--- a/drivers/staging/comedi/drivers/dt9812.c
+++ b/drivers/staging/comedi/drivers/dt9812.c
@@ -422,6 +422,8 @@ static void dt9812_configure_gain(struct comedi_device *dev,
                rmw->or_value = F020_MASK_ADC0CF_AMP0GN2 |
                                F020_MASK_ADC0CF_AMP0GN1;
                break;
+       default:
+               /* this should never happen, just use a gain of 1 */
        case DT9812_GAIN_1:
                rmw->or_value = 0x00;
                break;
@@ -438,9 +440,6 @@ static void dt9812_configure_gain(struct comedi_device *dev,
        case DT9812_GAIN_16:
                rmw->or_value = F020_MASK_ADC0CF_AMP0GN2;
                break;
-       default:
-               dev_err(dev->class_dev, "Illegal gain %d\n", gain);
-               break;
        }
 }
 
-- 
1.8.1.4

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

Reply via email to